search

Codeinwp / raft

Issues should be created in https://github.com/Codeinwp/otter-blocks
7 stars 2 forks source link

All Archives template - inherit query from template #107

Closed JohnPixle closed 6 months ago

JohnPixle commented 6 months ago

A user reported this through email, and looks like we can fix this easily. The issue is that the query block, should inherit the template query, since it is part of the template. The fix is simple, need to add the "inherit":true in the block's meta. I will make a PR.

📌 UPDATE: Looks like a false alarm, I got confused because I looked at the demo, which had a customised template I was working with, after checking the master files, the query blocks are configured properly I will wait to see if client has any feedback (he was experiencing some issues with the query), and might close this issue.

inherit

HardeepAsrani commented 6 months ago

It is the case already as you pointed out in your update: https://github.com/Codeinwp/raft/blob/master/templates/archive.html#L19

JohnPixle commented 6 months ago

@HardeepAsrani yes, I am closing the issue, sorry for the false alarm.