Closed abaicus closed 1 year ago
Following up here, I have created some patterns and added them in the demo in a new page.
On top of that, I spotted some layout issues with 3 of our existing patterns and the latest GB version, so I will try to fix those as well.
I don't recall how we managed the process the last time 🙃. I understand that the patterns are located in this folder: https://github.com/Codeinwp/raft/tree/master/inc/patterns
My idea is:
Or will I completely destroy things this way?
Please advise @abaicus 🥺
@JohnPixle Yes, the process is correct. There's one more thing you need to do for this to work. You must add the filename without extension here: https://github.com/Codeinwp/raft/blob/master/inc/Block_Patterns.php#L65-L76.
If you need any help, let me know!
Another thing to remember is that we should not add strings with the new patterns. We can try reusing some that we already have in other patterns.
Also, we have to provide images from the patterns in the theme, similar to how we already do it in existing patterns.
If you want, we can simplify the process. You can simply add the patterns in some .html
files and I can handle converting and adding everything afterward. 👍🏻
Thanks @abaicus!
I will be honest, I think I will just add the content HTML files and share them with you. I am pretty sure I would mess something up.
I will do the same for the extra template parts I created (header footer). Will keep you updated!
@abaicus I am back with the new patterns HTML files. Had to do a bit more testing and make sure they worked well on all style variations and I adjusted a couple of risky ones.
Here is the zip containing 11 htmls:
As a reminder, the updated patterns are also live on this page: https://demosites.io/raft/patterns-update/
I also created two template parts, one header and one footer. The zip below contains them both.
Here is a screenshot for a visual reference for them. I am not sure happy with them to be honest, there are limitations in the responsiveness (especially for the header) so this is the best I could come up with.
I will follow up with templates for Singles and Archives.
Please keep me in the loop in case you face any issues, need any clarifications or help in general.
Thanks! 🚀
@JohnPixle, Is there a chance I can get as SVG all the images used in the new patterns, please? We did this for the initial patterns, so everything will look crisp.
Also, I just noticed that the lightbulb icon seems to have a small issue on the left side of the filament:
@abaicus So sorry about that 😟. I dont know why, but I was under the impression that we were using pngs, and I actually wanted to suggest the use of SVG. Dont know why I got confused. Anyway.
Many of the images I used for the new patterns were already included in the old patterns, I see the assets here: https://github.com/Codeinwp/raft/tree/master/assets/img.
Give me a few minutes and I will get you the extra ones with consistent file naming as the old ones.
We use SVG-s in the patterns, but the user can't natively upload SVG files to WP. I think that's probably the reason for the confusion 👍🏻
@abaicus Yeah, probably. Anyway, I exported any new images used in the patterns, in SVG. Attaching the zip here. newSVGs.zip
In case it helps, I am also attaching this screenshot from Figma which gives an overview of old vs new images.
Let me know if this helps. I am around in case I can do something to make things easier for you in the process.
:tada: This issue has been resolved in version 1.0.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
https://demosites.io/raft/patterns-update/
@JohnPixle Keeping you in the loop. Just adding this here so we can track things. 👍🏻