Codeinwp / raft

Issues should be created in https://github.com/Codeinwp/otter-blocks
7 stars 1 forks source link

Update the demo site #37

Closed ineagu closed 1 year ago

ineagu commented 1 year ago

Description

The current demo site looks bad on mobile for e.g ( the header) and can use more elements + a way to switch between styles.

Can we do a proper demo for this? As I was thinking to promote it with the 6.2 release, this would be helpful.

Step-by-step reproduction instructions

Go to : https://demosites.io/raft/

Screenshots, screen recording, code snippet or Help Scout ticket

No response

Environment info

No response

Is the issue you are reporting a regression

No

HardeepAsrani commented 1 year ago

@mghenciu can you help here with what more you think we can do to improve the design that works great on all screens?

selul commented 1 year ago

@ineagu, from my point of view the current demo is looking quite good for promotion and marketing; I don't see those as blockers in case they take too much to not promote it. Do you think otherwise?

ineagu commented 1 year ago

As I’ve mentioned is broken on mobile ( the heading take the whole screen), the default w.org preview looks better.We dont need anything fancy, just replicate the w.org oneSent from my iPhoneOn Mar 26, 2023, at 11:09, Marius Cristea @.***> wrote: @ineagu, from my point of view the current demo is looking quite good for promotion and marketing; I don't see those as blockers in case they take too much to not promote it. Do you think otherwise?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

selul commented 1 year ago

For me seems good as it looks https://vertis.d.pr/i/as5rAo

selul commented 1 year ago

Can you share your browser when you get some time https://www.whatsmybrowser.org/

ineagu commented 1 year ago

Here is on Safari, iphone for e.gSent from my iPhoneOn Mar 26, 2023, at 11:18, Marius Cristea @.***> wrote: Can you share your browser when you get some time https://www.whatsmybrowser.org/

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

selul commented 1 year ago

Sure, no need to rush; you can share the details whenever you get some time.

ineagu commented 1 year ago

9586CE89-A134-4B7F-9795-45C48A3A3794

Here is the screen on Safari, iphone, didn’t work in the last message.

ineagu commented 1 year ago

And wordpress.org DA376399-FF07-44FF-8035-1E35A510CCA7

ineagu commented 1 year ago

Here is the browser link https://www.whatsmybrowser.org/b/NVVC8

mghenciu commented 1 year ago

Should look better now: image

The issue was caused by a Custom font value (72px) for the Main heading on the Homepage. At this stage, is not possible to have different font size on Desktop and Mobile in FSE. The only way to do this is with Code, by defining responsive font size values.

HardeepAsrani commented 1 year ago

Closing this as Mihai confirmed this was fixed, and creating a new issue for another issue that we found.