search

Codeinwp / raft

Issues should be created in https://github.com/Codeinwp/otter-blocks
7 stars 2 forks source link

Add text decoration underline on links #40

Closed stefan-cotitosu closed 10 months ago

stefan-cotitosu commented 1 year ago

What problem does this address?

Links are not currently emphasized in any way, so they are hard to be spotted, only the cursor changes when hovering over them.

What is your proposed solution?

Add text decoration underline on links like we have in Neve.

Requested here: https://secure.helpscout.net/conversation/2200852455/363944/

HardeepAsrani commented 1 year ago

@Codeinwp/design-team Just to confirm, do you have any input here before we go ahead with it?

mghenciu commented 1 year ago

https://github.com/orgs/Codeinwp/teams/design-team Just to confirm, do you have any input here before we go ahead with it?

The request makes sense, also from an Accessibility pov. The challenge we had with this before, is that there are cases when as a user/designer - you will not want those underlines visible. One example is when having a Posts Grid, and each title is a link - in this case the underline makes things look bad.

So if we go for this, I would use the Core 2023 theme as a reference - since they improved some of the things I mentioned above (example below), compared to 2022 - and not just applying the underline everywhere: Screenshot 2023-04-19 at 14 46 09

HardeepAsrani commented 1 year ago

Thank you @mghenciu, we will keep that in mind.

JohnPixle commented 1 year ago

Yes, exactly what Mihai said above. Let's keep TT3 as a reference. There are many cases where an Underlined link would be un-wanted from a design perspective.

Let us know if you need any clarifications Hardeep, at any point. Thanks for taking care of this.