Codeinwp / raft

Issues should be created in https://github.com/Codeinwp/otter-blocks
7 stars 1 forks source link

Footer Credits/Menu looks weird in mobile #41

Closed HardeepAsrani closed 8 months ago

HardeepAsrani commented 1 year ago

Description

If you see the Raft footer in mobile devices, it looks bit weird with Credits taking most of the space. We can investigate if it's possible to solve it without using any custom CSS, ie using Block Editor settings. Thanks @mghenciu for bringing this to attention.

Step-by-step reproduction instructions

  1. You can see the WPorg preview in the mobile: https://wordpress.org/themes/raft/
  2. Or you can have a wp instance with a lot of menu items to see the issue.

Screenshots, screen recording, code snippet or Help Scout ticket

Screenshot 2023-04-21 at 4 51 54 PM

Environment info

No response

Is the issue you are reporting a regression

No

mghenciu commented 1 year ago

Hey, @arinaturcu . I think the solution is to just enable the Stacking for the row that contains footer elements, like this:

Screenshot 2023-04-24 at 12 18 19

And the Footer template part would change to this:

footer.html.zip

and Footer with columns, like this: footer-with-columns.html.zip


I've made this commit, that should address the issue. Let me know if I can help with something else.

arinaturcu commented 1 year ago

@mghenciu Thanks for taking care of it! 🚀

I made a build with your commit, so that the @Codeinwp/qa-team can test it: raft.zip

HardeepAsrani commented 1 year ago

@mghenciu Just one question, do you think it's fine from design perspective to have footer credit above the menu items? I know it's not possible to reverse them using block editor settings, but do you think it's a good compromise?

Screenshot 2023-04-24 at 6 01 58 PM
mghenciu commented 1 year ago

Not ideal, but I think we can live with it. Since having the Copyright on the left side is consistent with Neve, Jaxon, Fork, etc.