search

Codeinwp / raft

Issues should be created in https://github.com/Codeinwp/otter-blocks
7 stars 2 forks source link

Caption color doesn't apply as it's overwritten #56

Closed stefan-cotitosu closed 10 months ago

stefan-cotitosu commented 1 year ago

Description

When using an image with a caption, it is possible by editing Styles -> Colors to set a custom color for the caption.

The color set doesn't apply as it's overwritten by another value.

Step-by-step reproduction instructions

  1. On a sample page, add an image with caption and type something in there
  2. Open the site editor and navigate to Styles -> Colors
  3. Edit the colors and set a custom color for the caption
  4. Visit the page and see that neither in the editor or on the front end the caption color applies

Screenshots, screen recording, code snippet or Help Scout ticket

styles caption-in-console

Reported here: https://wordpress.org/support/topic/posible-bug-limited-caption-customisation-in-raft-theme/#post-17019590

Environment info

https://pastebin.com/Xgeq8Cam

Is the issue you are reporting a regression

No

JohnPixle commented 11 months ago

I think we can fix this one on the upcoming next update, let me know if it's easy to do @HardeepAsrani Thanks!

HardeepAsrani commented 11 months ago

@JohnPixle I was looking into it, and it looks like now the theme.json allows us to style captions. I was thinking, we can probably move all the styling of caption that is possible from CSS to theme.json

Let me know your thoughts.

JohnPixle commented 11 months ago

@HardeepAsrani thanks! If we do that, it would be a good idea to do so for every other element that we can style. Currently we are defining styles in many locations of the theme, and it's getting a bit confusing.

...assets/css

I am thinking that if we do that, we will end up with a huge theme.json that would not be so readable.

Let me know your thoughts, thanks again! 🚀

HardeepAsrani commented 11 months ago

@JohnPixle I'd still be happier with a bigger theme.json than CSS files as users can customize things that are part of theme.json but overriding custom CSS might be tricky for people.

JohnPixle commented 11 months ago

@HardeepAsrani ok, makes sense, thanks for the insights. I align with you on this, let me know how I can help!

pirate-bot commented 10 months ago

:tada: This issue has been resolved in version 1.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: