search

Codeinwp / raft

Issues should be created in https://github.com/Codeinwp/otter-blocks
7 stars 1 forks source link

Number of items shown on blog doesn't respect the value from Settings->Reading #58

Closed stefan-cotitosu closed 8 months ago

stefan-cotitosu commented 11 months ago

Description

On a website with 4 posts, the blog page only shows 3 items despite the value set in Settings -> Reading.

With the WP default theme, the value mentioned is taken into consideration on the Blog page.

Step-by-step reproduction instructions

  1. Activate Raft on a website with at last 4 posts
  2. Configure a page as the blog page in Settings -> Reading, static page
  3. Visit the blog page and you'll see there are only 3 posts displayed and pagination enabled

With the Twenty Twenty-Three theme, the value set in Settings apply on the blog page.

Screenshots, screen recording, code snippet or Help Scout ticket

raft-blog-page

raft-blog-displayed

Reported here: https://secure.helpscout.net/conversation/2361470032/385548/

Environment info

https://pastebin.com/8ZqUwgf2

Is the issue you are reporting a regression

No

JohnPixle commented 10 months ago

@HardeepAsrani Is this something we can work on for the next release? Maybe it is something defined in the template / loop block 🤔

HardeepAsrani commented 10 months ago

@JohnPixle I've fixed it here while investigating, it was a very a basic comment change: https://github.com/Codeinwp/raft/commit/e9ea99fc05f6f290ff06ae37575b2315ffd0acb2