feat: remove core patterns & registed custom categories

Codeinwp / raft

Issues should be created in https://github.com/Codeinwp/otter-blocks

7 stars 2 forks source link

feat: remove core patterns & registed custom categories #71

Closed HardeepAsrani closed 11 months ago

HardeepAsrani commented 11 months ago

Summary

As part of pattern library re-organization, this PR removes the core patterns and registers new pattern categories.

Will affect visual aspect of the product

YES

Test instructions

Make sure Core Patterns don't load anymore.
Make sure Raft patterns are registered properly.

Closes #61.

pirate-bot commented 11 months ago

Plugin build for a317508741be0d4f361e586001db560215f2f77c is ready :bellhop_bell:!

Download Raft - build 🔗

JohnPixle commented 11 months ago

@HardeepAsrani Works in the sidebar, but when I attempt to Create a pattern, the core patterns are still available as options. Think we can do something here? It's not critically bad. None of the core patterns appear now btw 👍🏻

Let me know!

HardeepAsrani commented 11 months ago

@JohnPixle I tested with the latest version of WordPress and I'm not able to reproduce that. Can you give me more info?

JohnPixle commented 11 months ago

@HardeepAsrani sure, here ia super quick video of what I am describing: https://www.loom.com/share/612c9dd40de348dd92d90023a4b9b679

Let me know if this helps!

HardeepAsrani commented 11 months ago

@JohnPixle Thanks for the video. From your initial message, I had confused it with pattern and not pattern categories. I'll check if we can remove those as well.

HardeepAsrani commented 11 months ago

@JohnPixle After looking at it, there are few issues:

If a customer has some patterns registered already those core categories, they will be removed and put to Uncategorized which isn't ideal.
Second, there is no way to find which categories are just Core categories and not added by some plugin so we will either be maintaining a static list of Core categories or removing all of them, even ones registered by some plugins.

I'd go with not removing the categories. Let me know your thoughts.

JohnPixle commented 11 months ago

@HardeepAsrani Thanks for looking into it, I agree.

So, you suggest that we simply remove the core patterns, but keep the core categories, and any new category we want to add right?

HardeepAsrani commented 11 months ago

@JohnPixle Yes, to avoid breaking any existing site.

pirate-bot commented 10 months ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: