search

Codeinwp / raft

Issues should be created in https://github.com/Codeinwp/otter-blocks
7 stars 1 forks source link

Re order color palette and add dark bg #77

Closed JohnPixle closed 9 months ago

JohnPixle commented 9 months ago

Summary

In this PR i have re-ordered the color palette in order to achieve the primary and secondary accent colors to appear in the theme style preset thumbnail. Similar to what we had done in Neve FSE. Simply added primary and secondary to the 3rd and 4th position.

Additionally, I have included a new color variable for dark background, like we have in our other themes. I have done this for all existing theme style presets.

Lastly, improved the semantic naming of color variables:

Foreground >> Text Background Dark >> Dark Background Background Alt >> Light Background Foreground alt >> Inverted text

Will affect visual aspect of the product

Yes, but not directly, the new dark bg color is not being used anywhere, and additionally there has been no slug change.

Screenshots

Test instructions

Open the site editor, the primary and secondary accent colors should be visible on the thumbnails. Screenshot 2023-11-21 at 1 03 20 PM Additionally, a new slot for the dark bg color should be available in each style preset.

Screenshot 2023-11-21 at 12 56 45 PM

Closes #76

pirate-bot commented 9 months ago

Plugin build for 197df21a638c92dacdbd8db62f357594cf9712c1 is ready :bellhop_bell:!

JohnPixle commented 9 months ago

I just tested it on my instance and it's all good Hardeep ✌🏻

pirate-bot commented 8 months ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: