Codeinwp / raft

Issues should be created in https://github.com/Codeinwp/otter-blocks
7 stars 2 forks source link

Add new site template: Fullwidth with Header and Footer #79

Closed JohnPixle closed 8 months ago

JohnPixle commented 9 months ago

Currently, apart from the default page template that has a fixed content width, we have a fullwidth template (blank) that displays only the content, without the header and footer. But we don't have a full-width template that users can use with header and footer parts. This is quite useful, and I suggest we add this efficiency.

@HardeepAsrani This is the content for this template, let me know if it looks good and if you have any questions. If it does, feel free to register this in the theme.

<!-- wp:group {"style":{"spacing":{"margin":{"top":"0","bottom":"0"},"padding":{"top":"0","bottom":"0","left":"0","right":"0"},"blockGap":"0"}},"layout":{"inherit":false}} -->
<div class="wp-block-group" style="margin-top:0;margin-bottom:0;padding-top:0;padding-right:0;padding-bottom:0;padding-left:0"><!-- wp:post-content {"layout":{"type":"constrained","contentSize":"100%"}} /--></div>
<!-- /wp:group -->

<!-- wp:template-part {"slug":"footer","theme":"raft","tagName":"footer"} /-->
HardeepAsrani commented 9 months ago

@JohnPixle Not sure if it's intended or not but in your code, I don't see the header. That's a mistake, right?

JohnPixle commented 8 months ago

@HardeepAsrani I don't know how I managed to lose that part, but yes, it was a mistake 🙈

pirate-bot commented 8 months ago

:tada: This issue has been resolved in version 1.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: