search

Codeinwp / raft

Issues should be created in https://github.com/Codeinwp/otter-blocks
7 stars 2 forks source link

Define text strings in core.php #86

Closed JohnPixle closed 8 months ago

JohnPixle commented 8 months ago

Summary

Following our discussion in Slack, I added the global strings in the core.php file, and I also created the function. Please review and merge if everything is good to go.

Will affect visual aspect of the product

NO

pirate-bot commented 8 months ago

Plugin build for 0cf1832311fc10ac2436e59b153e674471d297e1 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for 1083d444e3c1a4db4178af8213f8758017674511 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for 09018779afee3355bd440af93e482f73098f5688 is ready :bellhop_bell:!

JohnPixle commented 8 months ago

@HardeepAsrani fyi, I have done what we discussed in this PR.

I added the strings in core.php, created a function, and then I added a new pattern as a test. let me know if things work!

pirate-bot commented 8 months ago

Plugin build for 08ff5dacd8b2d3fde1655c8253261d914025a959 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for 884e74cde78b5eff0d7b2ad01b8307ed75fa52d4 is ready :bellhop_bell:!

JohnPixle commented 8 months ago

Thanks for the insights here. I will merge this now 🚀

pirate-bot commented 8 months ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: