search

Codeinwp / raft

Issues should be created in https://github.com/Codeinwp/otter-blocks
7 stars 2 forks source link

New patterns #87

Closed JohnPixle closed 8 months ago

JohnPixle commented 8 months ago

Summary

All strings and images in these patterns reference the variables we have created for strings.

Will affect visual aspect of the product

NO

Test instructions

Closes #.

pirate-bot commented 8 months ago

Plugin build for de2f4e4ff94e6cdfb2d690b9635c73e268095088 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for 6ff6c1dc3854e238fa56e3424207281ed8b98fef is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for b84d628cb3574b0cccefc27df34096ecfb4cce70 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for 4386b98421905f646c42f89d072823c5a674e033 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for e5cb343b53ab70580d375b0a2e167b5d4a09bf01 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for abc64d392fe066d7f0a635307fc72a8440d61a67 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for f32bbdcb63ed799eae63a6a4c4a98aed296e91f4 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for 6f3845f206b096f88f5e700ba884df58d509821a is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for eb64b17e6666ec49eceef3c6d3b092c6be5b8767 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for 2a029a83fa3be7f34332997047c20b34b3265ace is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for 28ae290b23dc7acfaff47c079fc3861ca34af6b2 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for 1f4d10fec011743c007f5bd9456a2b5c952cfc24 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for c81b8648797e078b81bc49143d98330ba2442cb8 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for ed2d5a39f3f4b39fe8c48993ec68893893f3b51d is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for 119caa0058678cb44a9950973eca59061d6bd084 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for 0d08cd9f5495167ade2db62626b0e3aa19cd6776 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for 0a2e80ecdd8803d8b9d9160775baf3b352e138e8 is ready :bellhop_bell:!

JohnPixle commented 8 months ago

Hey @HardeepAsrani quick summary/update for when you see this.

Made significant progress so far with the patterns. 🚀 I plan to work on the page layouts today and start wrapping things up.

Regarding the patterns in this PR, there are some soft issues with the markup it seems from the failing tests, like the ones you pointed out. I tried to work in a code space but faced some blocks, and did not want to disturb you as it was late.

In any case, I have uploaded almost of the new patterns, every string is now mapped to the global variables we created. I tested the build, and all they are all working fine, I only seem to have issue only in four of them, that appear as they need repair (screenshot).

Screenshot 2023-12-06 at 1 41 07 AM

You can see them right away by using this magic login and then going to the pattern library

If we have the time, I will re-work the existing patterns as well, but I'll wait for your insights and review on these ones first.

That's it for now, let me know how I can help ✌🏻 Thanks a lot for the help and guidance so far.

pirate-bot commented 8 months ago

Plugin build for ccb4d39fca9a63239522e36d440034bfdb7096ff is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for b21ef65f8946ddc27c0926ea35ac7aed782e4a38 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for 8a6b10c3c8264b48cd82bc6f741aa393e87da168 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for bc57c52fd3e1a65a43e6116d4f25157a4325ef32 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for 7c56e58adf3be9b73ef8cf398ca34b3aeb9febd9 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for 2bd6511e945ed2dbb8811dd560d03b521ad9987f is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for 1bef484b2097a884954b8560ffef15b22242e7fa is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for 8f7dac52d2db8511cbb1a315f7be344ddcd898cd is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for e5b5c80ecae31abef04ba3ee246226b3fa9b31c5 is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for 693c22e2aeeabe3cc7e4c2cb0945821d4e8592ae is ready :bellhop_bell:!

pirate-bot commented 8 months ago

Plugin build for e8e58cbcc05f9403ea8f18f088a743d9e37740e0 is ready :bellhop_bell:!

JohnPixle commented 8 months ago

Hey @HardeepAsrani , just wanted to set some perspective here if possible. I think we should prioritise with the review and merging of this PR, it has a bunch of changes, mainly the addition of new patterns and pages.

We need to start consolidating things and shape-up the theme with all the final material (patterns/templates/pages) included, so we can test holistically with the onboarding.

I need you to review overall, and investigate some rendering issues with 4 patterns that I have faced problems with. Other than that, things appear to be working well.

Testimonial Columns with Rating

Feature Cards

Testimonial Cards

Pricing Plans 4

rendering

Pattern Library at the Demo

If you want, you can see the full pattern library in the demo site.

Magic login here, and then go to pattern library. You should see all the patterns there,

Check also the full-page patterns in the pages category. I made them composite, referencing other patterns (wherever possible), like you suggested. Homepage 2 Page Example

Last but not least, I think this PR here is important to merge first, if we want to finalise the templates in this one: https://github.com/Codeinwp/raft/pull/85

Thanks! Please don't hesitate to ping me for any help or clarifications at any point.

pirate-bot commented 8 months ago

Plugin build for 5461d14c5689814835e8da98282e5dbe6451ba48 is ready :bellhop_bell:!

HardeepAsrani commented 8 months ago

@JohnPixle I've fixed the resolving errors in blocks. Let me know if all is good.

JohnPixle commented 8 months ago

@HardeepAsrani Thanks, looking perfect now. Just out of curiosity, what was the problem with these patterns? I almost fried my head to debug them, but eventually gave up 😆 . Thanks anyway!

HardeepAsrani commented 8 months ago

@JohnPixle God knows, I just copied and pasted them back from the patterns website that you have over at instawp. So might have been something during the exporting/importing.

pirate-bot commented 8 months ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: