search

Codeinwp / raft

Issues should be created in https://github.com/Codeinwp/otter-blocks
7 stars 2 forks source link

defines outline button styles in theme.json #88

Closed JohnPixle closed 8 months ago

JohnPixle commented 8 months ago

Summary

Adds style definitions for the outline button variation in theme.json This addresses an old issue where the padding for the outline style was overriden by core.

Resources: https://fullsiteediting.com/lessons/modifying-block-style-variations-via-theme-json/

Will affect visual aspect of the product

YES. Both buttons should be consistent in size.

Screenshots

Screenshot 2023-12-07 at 1 07 47 PM

Test instructions

Try to insert buttons, switch between default and outline, and see if the styles are consistent in terms of size. Please double-check indentation and format. ✌🏻

Closes #.

pirate-bot commented 8 months ago

Plugin build for b97685d5331fd8529fab91b983e693f88404c995 is ready :bellhop_bell:!

JohnPixle commented 8 months ago

If this is ok-to-go Hardeep, feel free to merge it. Thanks for the help!

pirate-bot commented 8 months ago

Plugin build for 5f27154d52f5e38dc3f247c5a0ac50773c07668a is ready :bellhop_bell:!

pirate-bot commented 8 months ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: