Replace strings and spacing in old patterns

Codeinwp / raft

Issues should be created in https://github.com/Codeinwp/otter-blocks

7 stars 2 forks source link

Replace strings and spacing in old patterns #96

Closed JohnPixle closed 8 months ago

JohnPixle commented 8 months ago

Summary

This replaces all the text strings and spacing values that we had in our old patterns, with string and spacing variables.

Will affect visual aspect of the product

Test instructions

Browse the pattern library, and see that all patterns appear without rendering issues.

pirate-bot commented 8 months ago

Plugin build for f2c1fd81f660819435ff0095a459c2191d02effc is ready :bellhop_bell:!

Download Raft - build 🔗

pirate-bot commented 8 months ago

Plugin build for 855d5be300a9210ad2aa5f782fbe6f9dd8778f62 is ready :bellhop_bell:!

Download Raft - build 🔗

pirate-bot commented 8 months ago

Plugin build for e276532e9f139fd55512760e063758965055d88f is ready :bellhop_bell:!

Download Raft - build 🔗

pirate-bot commented 8 months ago

Plugin build for 4bd827abcafd3954fdfdecfab848d3cd1df30314 is ready :bellhop_bell:!

Download Raft - build 🔗

pirate-bot commented 8 months ago

Plugin build for f9dfdb90d127e449fe7039e382a629cc363961d1 is ready :bellhop_bell:!

Download Raft - build 🔗

pirate-bot commented 8 months ago

Plugin build for fbaa8a48445e138ec2c1b8565f9640d8fe40fb25 is ready :bellhop_bell:!

Download Raft - build 🔗

pirate-bot commented 8 months ago

Plugin build for aa62e7d66909c7f642561ebbfc16c8a4fe31538f is ready :bellhop_bell:!

Download Raft - build 🔗

pirate-bot commented 8 months ago

Plugin build for 0f1dd2362bf23938b56b47595b4f58def1f1b74c is ready :bellhop_bell:!

Download Raft - build 🔗

pirate-bot commented 8 months ago

Plugin build for 44c3f8b7a2810f3dbde279931cfcd921b49cddd3 is ready :bellhop_bell:!

Download Raft - build 🔗

pirate-bot commented 8 months ago

Plugin build for 59fe9b5a005a0364b87c3ca882da87e402e9a15c is ready :bellhop_bell:!

Download Raft - build 🔗

pirate-bot commented 8 months ago

Plugin build for fa5547cee77ac7e2866e1c9965ccaee795701591 is ready :bellhop_bell:!

Download Raft - build 🔗

pirate-bot commented 8 months ago

Plugin build for bccce7ecbd1b50bb15db5a65c3defc143ed049e2 is ready :bellhop_bell:!

Download Raft - build 🔗

JohnPixle commented 8 months ago

@HardeepAsrani I eventually managed to rework our old patterns as well for consistency. I replaced all the text strings with the string variables, and also applied the new spacing vars in paddings, instead of inline px values.

I managed NOT to have any rendering issues for these ones 🚀 . You can view all patterns now in the pattern library of the demo site, but overall they are fine. magic login

You might just want to check the markup, and that failing test. Other than that, if it is ok I will merge it as well. Let me know!

pirate-bot commented 8 months ago

Plugin build for 224626b30b4b25634e9aa1f6b45000e95b808164 is ready :bellhop_bell:!

Download Raft - build 🔗

pirate-bot commented 8 months ago

Plugin build for 70cb9d5d385da48291c893e86d9ba404671625f0 is ready :bellhop_bell:!

Download Raft - build 🔗

pirate-bot commented 8 months ago

Plugin build for 47c7cb6c20bf326c139c268fc9c88bc44cab723c is ready :bellhop_bell:!

Download Raft - build 🔗

HardeepAsrani commented 8 months ago

LGTM, I've fixed the issue as well. Feel free to merge.

pirate-bot commented 8 months ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: