Closed abaicus closed 6 years ago
@abaicus
When you have a lot of menu items, the menus dashboard page freezes the browser.
does this freeze on page load or when you try to select an icon?
When adding a new element to the menu, there are two add icon buttons.
when adding a new element, its usually added at the bottom but in the issue it seems like its being added at the top. I cannot seem to reproduce the issue; maybe it is a specific scenario?
@contactashish13
LATER EDIT: The new element is added at the bottom but the first element gets another iconpicker from what I remember.
@abaicus
When the menu contains invalid menu items (pages / posts that have been deleted), sometimes it throws a js error.
can you please list down the steps to reproduce this? for me, this is what it shows after I delete a post that was added to the menu (and no JS error):
Try adding a lot of menu items in the menu - also submenus. I'm talking about a lot more menu items.
Can't get the second js error to come up either. I don't know why.
@contactashish13 please have a look at that HS ticket that andrei assigned to you.
@selul @abaicus https://github.com/Codeinwp/themeisle-companion/pull/134 should fix these issues. Can you please test locally in case I've forgotten to test a scenario and then I can apply this on the customer's instance?
@abaicus did you manage to test it ?
@contactashish13 This happens when you drag and drop any menu item on my instance. Another plus appears.
@abaicus have addressed this. can you please test again?
Still getting this when trying to move anything. Loading seems to be improved though. 👍 @contactashish13
@abaicus can you try to clear your cache and test as most of these changes are in the JS file?
My cache is cleared. Also happens under Safari and Firefox, which are browsers from where I've never accessed this.
@abaicus I didn't notice the error before. I've addressed it now.
Seems to be working fine now! 👍
When you have a lot of menu items, the menus dashboard page freezes the browser.
This is probably because of the multiple iconpickers and because they parse the icons array dinamically.
When adding a new element to the menu, there are two add icon buttons.
The two buttons appear on the top menu item.
When the menu contains invalid menu items (pages / posts that have been deleted), sometimes it throws a js error.