Codeinwp / themeisle-companion

Orbit Fox Companion
GNU General Public License v2.0
13 stars 18 forks source link

Update Twitter icon/name #836

Open AndreeaCristinaRadacina opened 6 months ago

AndreeaCristinaRadacina commented 6 months ago

What problem does this address?

A user asked about updating the Twitter icon and name in the social sharing module:

image

https://secure.helpscout.net/conversation/2539624941/409037?viewId=931544

What is your proposed solution?

Update the icon and name.

Will this feature require documentation? (Optional)

None

Soare-Robert-Daniel commented 6 months ago

One problem here is that for the social module, we use this lib https://github.com/ericakfranz/socicon to display the icons. The problem is that lib is not updated anymore, so it does not have the latest icon for X/Twitter.

I suggest using Font Awesome directly. So we will need to remove the deps on Socicon and update FA to the latest version.

Soare-Robert-Daniel commented 5 months ago

One problem here, the latest version of Socicon does not have the new Twitter logo. The FA version is missing some Chinese brands, like Baidu, which we have available to use.

Socicon repo: https://github.com/Ybbet/socicon/tree/main FA6 brands: https://fontawesome.com/search?o=r&f=brands

Image

pirate-bot commented 5 months ago

:tada: This issue has been resolved in version 2.10.35 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

Soare-Robert-Daniel commented 5 months ago

[UPDATE] The new X icon has been introduced in the font: https://github.com/Ybbet/socicon/issues/9