Codeinwp / tweet-old-post

Plugin to tweet about your old posts to get more hits for them and keep them alive.
GNU General Public License v2.0
13 stars 16 forks source link

Upgrade fb api graph version #1003

Closed selul closed 2 weeks ago

selul commented 3 weeks ago

What problem does this address?

We can look into using the latest API graph version since right now we are using an older one.

What is your proposed solution?

No response

Will this feature require documentation? (Optional)

None

selul commented 3 weeks ago

@vytisbulkevicius we need to address this in the next 2 weeks since the current version will no longer be supported after half of see https://github.com/Codeinwp/tweet-old-post-pro/issues/558

vytisbulkevicius commented 3 weeks ago

I see the version defined here - https://github.com/Codeinwp/tweet-old-post/blob/master/includes/admin/services/class-rop-facebook-service.php#L766

And https://github.com/Codeinwp/tweet-old-post/blob/master/includes/admin/services/class-rop-facebook-service.php#L764

I don't see version used in PRO version anywhere.

I don't see it elsewhere, but can you check @girishpanchal30 as well? https://developers.facebook.com/docs/graph-api/changelog

girishpanchal30 commented 3 weeks ago

I don't see it elsewhere, but can you check @girishpanchal30 as well?

@vytisbulkevicius I'll check and let you know here

selul commented 3 weeks ago

we need to check also the app site, https://github.com/Codeinwp/rop-auth-service

girishpanchal30 commented 3 weeks ago

@selul could you please provide test Facebook app credentials so I can connect it to my local setup?

Here: image

girishpanchal30 commented 3 weeks ago

@selul I've checked, and the ROP APP is supportsv16.0, so I think we don't need any major changes. Ref: https://github.com/search?q=repo%3ACodeinwp%2Frop-auth-service%20default_graph_version&type=code

Please review this PR and share your thoughts.

Thanks

selul commented 3 weeks ago

@girishpanchal30 is there any issue if we use the latest? I don't have any test app, feel free to create one.

girishpanchal30 commented 3 weeks ago

@selul I've tested v20.0 and I don't see any issue locally.

I see that ROP also has a staging environment, which we can test here.

https://github.com/Codeinwp/rop-auth-service?tab=readme-ov-file#revive-old-post-central-auth-service

I've opened a new PR for the ROP app, can you please merge it into development?

For testing, we need to change the app URL here - https://github.com/Codeinwp/tweet-old-post/blob/master/tweet-old-post.php#L177

selul commented 3 weeks ago

I've merged it.

girishpanchal30 commented 3 weeks ago

I'll check and let you know, Thanks

girishpanchal30 commented 3 weeks ago

@selul While I tested with staging it seems authentication is working fine but after authentication ROP app returns an empty pages list on staging. Ref: https://tinyurl.com/27kdcfo9

I've tested it before merging the PR, and the results are the same.

Ref: https://tinyurl.com/23t4ewuk

@Soare-Robert-Daniel @selul Do you have any idea about this error?

Thanks

selul commented 3 weeks ago

seems like it was out of sync the branch, I've synced it.

girishpanchal30 commented 3 weeks ago

@selul Now it working fine and also post sharing is working. Ref: https://tinyurl.com/22xbkal4

Thanks