Codeinwp / tweet-old-post

Plugin to tweet about your old posts to get more hits for them and keep them alive.
GNU General Public License v2.0
12 stars 16 forks source link

add rebrandly support #166

Closed ineagu closed 6 years ago

ineagu commented 6 years ago

@selul we should add support for rebrandly shortner. https://www.rebrandly.com

UVLabs commented 6 years ago

I've used rebrandly, and unless the links to the posts are always kept the same (let user be able to set rebrand link and save to db so post always uses that same link) this would make the rebrandly dashboard a mess if the user actually wants to track this from the dashboard

A good approach might be the same way we allow custom messages, and if there's no preferred rebrand link set for a post it would just use a fallback shortener or none at all

If we do decide to go that route then it would be best to give those links their own table imo

UVLabs commented 6 years ago

I'm assuming the rebrandly api would allow for setting of custom links and syncing them with the user rebrandly dashboard

ineagu commented 6 years ago

good point, we should always use same links for same post

On Wed, May 2, 2018 at 4:07 PM, Uriahs Victor notifications@github.com wrote:

I'm assuming the rebrandly api would allow for setting of custom links and syncing them with the user rebrandly dashboard

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Codeinwp/tweet-old-post/issues/166#issuecomment-386010970, or mute the thread https://github.com/notifications/unsubscribe-auth/ABw6DDcJkeGBb7pzVjl6BqcIwq_DI4arks5tucuqgaJpZM4TuBWJ .

-- Ionut Neagu http://themeisle.com | http://codeinwp.com | http://ionutn.com

UVLabs commented 6 years ago

@contactashish13 can you please take care of this? Don't think I'd have time get to it before we need to release the new versions https://developers.rebrandly.com/

contactashish13 commented 6 years ago

@UVLabs I see potential problems with saving the shortened URL per post. The URL of the post can change and not just through the edit post option. If we need to update rebrandly with the new URL, we could be looking at many off-plugin events. I feel this changing of URL to update rebrandly is a rare case. Also, I'm sure the same thing happens with other shorteners and their dashboards and we are not addressing that.

selul commented 6 years ago

@contactashish13 for the moment I think we can use it as we use other shorteners, nothing new. Just for wraping up the link before sharing with the rebrandly shortlink.

Other things like analytics, dashboard or similar might be tackled lately.

You can think of integrating it as another shortner provider.

cc @UVLabs

UVLabs commented 6 years ago

We can go ahead and just use it as a regular shortner as Marius suggested, based on what users say I guess we can later work more on this

contactashish13 commented 6 years ago

@UVLabs PR: https://github.com/Codeinwp/tweet-old-post/pull/202

contactashish13 commented 6 years ago

@UVLabs PR: https://github.com/Codeinwp/tweet-old-post/pull/206