Codeinwp / tweet-old-post

Plugin to tweet about your old posts to get more hits for them and keep them alive.
GNU General Public License v2.0
12 stars 16 forks source link

Rviv.ly not always returning link #331

Closed UVLabs closed 5 years ago

UVLabs commented 5 years ago

Facebook returns invalid parameter

Linkedin returns error requiring submitted link

Twitter doesn't include the link

etc

UVLabs commented 5 years ago

Issue seems to be with rvivly creating new links

mariusvetrici commented 5 years ago

@UVLabs pls provide here:

UVLabs commented 5 years ago

To test:

Because of these lines: https://github.com/Codeinwp/tweet-old-post/blob/master/includes/admin/shortners/class-rop-rvivly-shortner.php#L77-L79 if the shortening does not work then it will return the original URL, when actually it should be returning the shortened URL.

mariusvetrici commented 5 years ago

I believe the rviv.ly server is the culprit here, there's nothing to be fixed in the plugin itself.

None of my posts could get a valid URL from rviv.ly, the response is always code 200 with an empty body instead of the short URL. Performing the request via Postman yields the same result (Screen). Omitting the signature parameter returns the correct response for that scenario (Screen), so the server seems to be functional, just not processing URLs properly.

I tried using different URLs, from my local env, from our online staging, from other online sites.

I also tried using "signature" and "website" values containing our "http://rop.ernomo.re" staging to make sure the problem wasn't that rviv.ly could not reach my local env. Still an empty response.

Alex N.

selul commented 5 years ago

Indeed, you were right. I did check the rviv.ly server and it had an issue, now it should be working fine.

mariusvetrici commented 5 years ago

Looks good! Twitter: https://d.pr/i/t1Xize Linkedin: https://d.pr/i/GI34wK

The issue will be moved directly to Done since it was investigated and discussed with the team.