search

Codeinwp / tweet-old-post

Plugin to tweet about your old posts to get more hits for them and keep them alive.
GNU General Public License v2.0
13 stars 16 forks source link

Latest update requires PHP v7.4 #879

Closed purplecodes closed 1 year ago

purplecodes commented 1 year ago

Description

ROP requires at least PHP v7.2 or higher and this is also displayed in wp.org. https://vertis.d.pr/i/aBd2JD

But since the last update (v9.0.15), some free users are reporting that they are getting the error below:

_Fatal error: Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 7.4.0". You are running 7.3.33-10+ubuntu20.04.1+deb.sury.org+1. in /s1-suspendship/wordpress/wp-content/plugins/tweet-old-post/vendor/composer/platformcheck.php on line 24 There has been a critical error on this website. Please check your site admin email inbox for instructions.

If this is the new requirement, please update the PHP version requirement on wp.org. It would be good as well if there is a way for us to inform the users before they update as they will be locked our from their WordPress Dashboard if they have a lower PHP version than required.

Step-by-step reproduction instructions

Steps to replicate:

  1. Install and activate the Revive Old Posts plugin.
  2. If your version of PHP is lower than v7.4, you will most likely get the error stated above.

https://vertis.d.pr/i/m9Zob1

Ticket: https://wordpress.org/support/topic/latest-update-breaks-site-with-php-7-3/

Is the issue you are reporting a regression

Yes, this is a regression.

girishpanchal30 commented 1 year ago

@purplecodes Now some composer packages required 7.4 or above PHP version, we need to update the readme.txt file in wp.org @vytisbulkevicius Can please you please update the readme file? PR https://github.com/Codeinwp/tweet-old-post/pull/880

gingerbeardman commented 1 year ago

The plugin functionality didn't change, so why does requirements?

Only because of some composer packages?

It is surely possible to avoid using those things that needs 7.4? Then we could retain current compatibility.

girishpanchal30 commented 1 year ago

Only because of some composer packages?

Yes, abraham/twitteroauth package required a 7.4 or above PHP version. image

Thanks

pirate-bot commented 1 year ago

:tada: This issue has been resolved in version 9.0.16 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

vytisbulkevicius commented 1 year ago

@girishpanchal30, readme.txt file was updated but data on wordpress.org was not changed (related to min PHP version required).

Seems like we need to change it here also - https://github.com/Codeinwp/tweet-old-post/blob/master/tweet-old-post.php

vytisbulkevicius commented 1 year ago

Ignore this, the release is done and the min PHP version appears correctly now.

gingerbeardman commented 1 year ago

Only because of some composer packages?

Yes, abraham/twitteroauth package required a 7.4 or above PHP version. image

Thanks

Soon this package will require PHP8

I think ROP should not be tied to such a package. There are other Twitter OAuth packages that do not require the latest PHP.