search

Codeinwp / tweet-old-post

Plugin to tweet about your old posts to get more hits for them and keep them alive.
GNU General Public License v2.0
10 stars 16 forks source link

fix: run instant sharing only on published posts #932

Closed Soare-Robert-Daniel closed 2 months ago

Soare-Robert-Daniel commented 4 months ago

Closes https://github.com/Codeinwp/tweet-old-post/issues/917

Summary

Instant sharing will now run only on posts with published as status. future has been removed from the allowed list.

Testing

  1. Install RoP with a social account.
  2. Activate instant sharing.
  3. Create a new post and schedule it.
  4. When pressing Schedule that post will NOT be shared to the social account.
  5. Create a new post, add some content then publish it directly. This post should be posted on the social.
github-actions[bot] commented 4 months ago

Plugin build for 65c72d427578b38d7fc9055dff3b6ddc6f1551aa is ready :bellhop_bell:!

irinelenache commented 4 months ago

@Soare-Robert-Daniel Tested and the issue is fixed now 👍

Regarding the scheduled posts, i didn't manage to share one. I unchecked the instant share in the post editor (https://vertis.d.pr/i/peBZUM), scheduled the post and nothing happened after the post was published. Here are the ROP settings: https://vertis.d.pr/i/FBiIz2

Soare-Robert-Daniel commented 4 months ago

Regarding the scheduled posts, i didn't manage to share one. I unchecked the instant share in the post editor (https://vertis.d.pr/i/peBZUM), scheduled the post and nothing happened after the post was published. Here are the ROP settings: https://vertis.d.pr/i/FBiIz2

@irinelenache, I could not replicate the problem. Can you share the instance?

vytisbulkevicius commented 3 months ago

Hey @irinelenache, can you check here when you have time if that issue still exists? Thanks!

Soare-Robert-Daniel commented 2 months ago

@vytisbulkevicius, I think we can merge this.

Having the schedules posted instantly seems to create more trouble for users since it might break their planned schedule than the fact that it might have a low chance of not being shared (they can always do it manually at the desired time)

pirate-bot commented 2 months ago

:tada: This PR is included in version 9.0.27 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: