Codeinwp / tweet-old-post

Plugin to tweet about your old posts to get more hits for them and keep them alive.
GNU General Public License v2.0
10 stars 16 forks source link

Sign in process doesn't allow for user input #955

Closed AndreeaCristinaRadacina closed 3 weeks ago

AndreeaCristinaRadacina commented 2 months ago

Description

A user reported that he can no longer choose the Facebook profile that should be linked to his WP instance.

Step-by-step reproduction instructions

  1. Go to ROP
  2. Try to connect to Facebook

The connection will be made, but you cannot input the profile or choose which pages to appear, as it was before.

Screenshots, screen recording, code snippet or Help Scout ticket

Once you click on sign in, this will appear:

image

ref:https://secure.helpscout.net/conversation/2590687579/418114?viewId=212385

Environment info

No response

Is the issue you are reporting a regression

Yes, this is a regression.

AndreeaCristinaRadacina commented 2 months ago

+1 https://secure.helpscout.net/conversation/2597543360/418836?viewId=212385

Soare-Robert-Daniel commented 1 month ago

This was caused by the re-authorization process, which tries to log in to the previously saved users. One quick way for the user to choose the profile is to use incognito mode so that Facebook does not reuse the cookies.

AndreeaCristinaRadacina commented 1 month ago

@Soare-Robert-Daniel I shared this solution, but the answer is not positive regarding the result.

Soare-Robert-Daniel commented 1 month ago

Besides this, we should also update the Facebook API version since Facebook is starting to move on: https://github.com/Codeinwp/tweet-old-post/blob/6c8d5852276b4ca3ab7090681d4f8c5397189de8/includes/admin/services/class-rop-facebook-service.php#L166

https://developers.facebook.com/docs/graph-api/changelog

Soare-Robert-Daniel commented 1 month ago

@AndreeaCristinaRadacina, I have reverted to the old behavior for authentication. You can keep an eye on if the users still have this difficulty.

AndreeaCristinaRadacina commented 1 month ago

As discussed, the login is possible, but the whole modal with permissions and page selection is gone.

Soare-Robert-Daniel commented 1 month ago

@AndreeaCristinaRadacina, we can not do too much on our part. Once permission has been granted, Facebook will not ask again (also mentioned in their docs).

Based on this, a possible solution for the users to re-add the asking stage is to remove the post permission in their Facebook dashboard, as shown in the video below.

If they have multiple websites, this approach might be problematic since if they do this for one website, the login on other websites might be revoked since the access key will be invalid.

Image

https://github.com/Codeinwp/tweet-old-post/assets/17597852/d6b508ea-ccb9-4259-b009-36c444b4e9aa

Soare-Robert-Daniel commented 1 month ago

@AndreeaCristinaRadacina, I tweaked the login process again, and the account selection is now showing on my end 🙏

AndreeaCristinaRadacina commented 3 weeks ago

@Soare-Robert-Daniel indeed, it works now!