search

Codeinwp / tweet-old-post

Plugin to tweet about your old posts to get more hits for them and keep them alive.
GNU General Public License v2.0
12 stars 16 forks source link

Restricted Instagram, Linkedin and GMB service for basic plan #988

Closed girishpanchal30 closed 3 months ago

girishpanchal30 commented 3 months ago

Close https://github.com/Codeinwp/tweet-old-post-pro/issues/527

pirate-bot commented 3 months ago

Plugin build for c4e7a6d8a028ad694ba640ac0d1990637a124970 is ready :bellhop_bell:!

rodica-andronache commented 3 months ago

@girishpanchal30 when using just the Free version, when you try to add an account for FB or Twitter, the layout of the page changes ( the buttons from the sidebar, move at the bottom of the page, in the background ). Also, the popup is more shrinked than before.
I tried to show this in the video, comparing it to the current version of the plugin https://vertis.d.pr/v/gSHuyV

girishpanchal30 commented 3 months ago

@rodica-andronache I've tested with local and it seems not to break any UI, Can you please share your test instance details here? Ref: https://tinyurl.com/263bsuvn

rodica-andronache commented 3 months ago

@girishpanchal30 

https://exotic-mamba-29f6e6.vertisite.cloud/wp-admin/admin.php?page=TweetOldPost
user: rodica
pass: rodica
girishpanchal30 commented 3 months ago

@rodica-andronache Now I've tested with local and browserstack it seems working properly. Please check the private window and let me know Ref: https://tinyurl.com/23qslh9s

rodica-andronache commented 3 months ago

@girishpanchal30 it's the same for me, in incognito or on browserstack https://www.loom.com/share/3782026dc5a944648c63511e88bab761?sid=60b50ea1-8e44-4bc4-bb95-6c919da75266

girishpanchal30 commented 3 months ago

@rodica-andronache Can you please recheck with the latest build zip? it seems issue with some style/css

rodica-andronache commented 3 months ago

@girishpanchal30 yes, that layout shift is not happening anymore. Just the popup for twitter appears different for me, than in the current version. Its smaller ( the title does not fit on one line ), and the button doesn't have a border anymore

Current version Screenshot on 2024-07-10 at 15-37-49

With this PR Screenshot on 2024-07-10 at 15-37-42

girishpanchal30 commented 3 months ago

@rodica-andronache Fixed, It happened because we have removed the modal footer notice(https://github.com/Codeinwp/tweet-old-post/pull/980) and some CSS issues with the new ROP version.

rodica-andronache commented 3 months ago

@girishpanchal30 thank you, now the popup is fine 👍 I'll wait for an answer from @stefan-cotitosu here https://github.com/Codeinwp/tweet-old-post-pro/issues/527#issuecomment-2220424132 to move it to Ready to Merge

pirate-bot commented 3 months ago

:tada: This PR is included in version 9.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: