Closed Soare-Robert-Daniel closed 2 months ago
Plugin build for 353351c2b464cfbc413ea5c918e29213a185ee5f is ready :bellhop_bell:!
@Soare-Robert-Daniel tested this and have two questions:
it's normal for the license key area to show up in the free version? I didn't see this mention in the issue and I find it really weird.
For tablets, I see that we are hiding the sidebar, or it's just not visible. In this case, the license key will also be hidden, and not accesibile to users. Not sure what the best approach would be here
@Soare-Robert-Daniel should I check here? Or are you still working on it? Thanks
@rodica-andronache, you can wait. The free user problem is solved, but we need to see a good solution for the design of the sidebar in the tablet view.
@Soare-Robert-Daniel we can add it under the publish button
The here link in the license key notice still points to Settings -> General instead of the ROP Dashboard page.
@Soare-Robert-Daniel, I tested on tastewp and I don't see the license key field.
The build for the free version so from this PR, and the pro version is the live one (from customer's area).
Instance details: https://pinpointhelp.s3-tastewp.com/wp-admin/ stefancoti JwIep3kE0J0
It's working on my website, and on Tastewp it seems to be a cache issue. So let's clarify the design on Tablet and we are good to go here.
@JohnPixle, can you please suggest a format for displaying the sidebar on Tablet, which can be full-width or limited?
@stefan-cotitosu I see the issue. The least painful solution for a decent layout on tablet would be to use a 2-column structure. I don't see any other viable option that would be easy to implement.
And in my opinion the columns do not even need to consume the full-width area as in your last screenshot, you could keep the widths as they help with readability.
Rough mockup 👇🏻
I would also like to point to your attention that the license number inside the field box is of very low contrast and is barely readable. Consider making the text darker, as in the description text.
Let me know if you need further help with that, I will be keeping an eye on the issue!
This is how it looks:
https://github.com/user-attachments/assets/1ae5bf8a-1bf1-4203-9ed2-4b2e88769875
:tada: This PR is included in version 9.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Summary
Moved the license to the dashboard page.
Screenshots
Free User
Activated
On Error
Testing
Check if you can activate/deactivate the license.