Codeinwp / visualizer

WordPress Visualizer plugin is a simple, easy to use and quite powerful tool to create, manage and embed interactive charts into your WordPress posts and pages.
106 stars 29 forks source link

Fix/470 #1153

Closed GrigoreMihai closed 4 months ago

GrigoreMihai commented 4 months ago

Summary

Changed the javascript rendering in favor of php side rendering for the pro charts lock.

Updated the pop-up links.

Added small changes to keep the code DRY.

Will affect visual aspect of the product

NO

Test instructions

Check that the pro charts lock notice is working as expected when a license is expired.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/visualizer-pro/issues/470.

pirate-bot commented 4 months ago

Plugin build for 187c7f6fc60eb79d14a9adc6064030cca1752f05 is ready :bellhop_bell:!

preda-bogdan commented 4 months ago

A small question related to this PR. Would it be too time-consuming to ensure these changes have some testing?

preda-bogdan commented 4 months ago

@GrigoreMihai Can you please fix the code style, the lint is failing. Thank you!

GrigoreMihai commented 4 months ago

@preda-bogdan I also added a test. I was also going to lint the code when pushing the test it was not ready for review when you looked.

It is all completed now, thank you for your patience!

pirate-bot commented 4 months ago

:tada: This PR is included in version 3.11.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: