Codeinwp / woocommerce-product-addon

PPOM for WooCommerce
4 stars 4 forks source link

Non required fields appear as required #369

Open poonam279 opened 6 days ago

poonam279 commented 6 days ago

Description

A user reported that non-required fields appear as required. We have already fixed this issue here: https://github.com/Codeinwp/woocommerce-product-addon/issues/316, but there is a new finding. The issue occurs if a required field is added before the non-required field.

Step-by-step reproduction instructions

  1. Create a meta group and add a required field first
  2. Now add a non-required field
  3. Attach it to a product
  4. Go to the product and don't fill in those not required fields, then try to add to cart

Screenshots, screen recording, code snippet or Help Scout ticket

Screenshot on 2024-09-11 at 22-54-30

Screenshot 2024-09-11 at 10 55 04 PM

HS Ticket: https://secure.helpscout.net/conversation/2702498320/433263?folderId=212385

Environment info

No response

Is the issue you are reporting a regression

No

girishpanchal30 commented 4 days ago

I've reviewed this issue and fixed it here - https://github.com/Codeinwp/woocommerce-product-addon/pull/376

poonam279 commented 4 days ago

@girishpanchal30 I have checked and the issue is fixed.