Codeinwp / woocommerce-product-addon

PPOM for WooCommerce
4 stars 4 forks source link

Show upsell popup when editing pro fields #373

Open girishpanchal30 opened 6 days ago

girishpanchal30 commented 6 days ago

Summary

Added upsell popup and show it when editing the lock field if a license is expired or not available.

Will affect visual aspect of the product

YES

Screenshots

https://tinyurl.com/2bmmgwuf

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/ppom-pro/issues/381

pirate-bot commented 6 days ago

Plugin build for ffbc0bc9dff7a59b723a4cd372f6fc5943c06ebe is ready :bellhop_bell:!

rodica-andronache commented 4 days ago

@girishpanchal30 I've tested with no license entered at all. In this case, I got these warnings Screenshot on 2024-09-14 at 10-15-15

Also, after clicking on the Renew License button, I am redirected to this, not sure if correct Screenshot on 2024-09-14 at 10-15-57

girishpanchal30 commented 2 days ago

@rodica-andronache I fixed the warnings and the Renew License URL is working for me, please check with the latest build zip.

AndreeaCristinaRadacina commented 2 days ago

@girishpanchal30 I tested it now, and it works as expected!

image

One question: should we add an overlay to make the rest of the screen not accessible anymore? Right now, while I have the alert on the screen, I can still perform other actions, like enabling/disabling fields:

image

I can even switch to the style tab and write some code.

girishpanchal30 commented 2 days ago

@AndreeaCristinaRadacina Added background overlay, please check with the latest commit.

AndreeaCristinaRadacina commented 2 days ago

@girishpanchal30, perfect! It works as expected!