Closed girishpanchal30 closed 1 year ago
Plugin build for 13905d2cad6a03fbc4262c8a90e8affd77819ff1 is ready :bellhop_bell:!
@girishpanchal30 can you do a rebase and check with the latest version how it behaves ?
@selul Sure, I'll check and update you here.
@selul
I have made some changes to make it compatible with the latest version. Now ticket is Ready for testing
.
May be QA team find out the issues. @irinelenache Can you please do a retest?
Thanks
@selul @girishpanchal30 I think we should make a clear decision about how this feature should work because now there are some issues happening:
Now on the network dashboard, i have the option to import a template even if pages are not available for this dashboard. If i try to import one and see the page, i'll get redirected to the main website's dashboard https://vertis.d.pr/l9bTxm
If i enable the Activated on all sites setting on the network dashboard , the individual setting will still appear as Deactivated on every subsite and in frontend i'm seeing the old design of the maintenance page https://vertis.d.pr/MPpKY1 . When i switch the status to Activated for every subsite in particular, i'll see the selected maintenance pages in frontend. After that, if i go again to the network dashboard and select the status as Deactivated for all sites, the maintenance pages will still be visible in frontend for the sites
My idea is to just have two simple controls on the network dashboard:
Let me know your thoughts on this 🙏
Also, you can check the issues i mentioned on this instance:
URL : https://multisite.s.themeisle.com/
Username : multisite
Password : RC8O3Z6M
@irinelenache
My idea is to just have two simple controls on the network dashboard:
- Yes/No option asking the user if he wants to manage the status from one place
- Status Activated/Deactivated (if the user selected yes for the first one)
The idea is very pretty and simple. We can ask Yes/No when the plugin is activated on the network site.
@selul what do you think?
Thanks
@irinelenache
I've implement your idea in this PR, please check with the PR build zip.
- Yes/No option asking the user if he wants to manage the status from one place
For this option, I've chosen to add a filter so the user can disable this feature.
add_filter( 'wpmm_manage_from_network_dashboard', '__return_false' );
Add this filter in your active theme functions.php file.
Status Activated/Deactivated (if the user selected yes for the first one)
Please check and let me know if you have any other suggestions as well.
Thanks
Close #295