Codeinwp / wp-maintenance-mode

Adds a splash page to your site that lets visitors know your site is down for maintenance. Full access to the back- & front-end is optional.
https://wordpress.org/plugins/wp-maintenance-mode/
159 stars 82 forks source link

Shortcode: Embed not working #308

Closed IlluminatePro closed 2 years ago

IlluminatePro commented 2 years ago

WP: 6.0.1 Version 2.4.7

Instructions say "[embed] - responsive video embed. Compatible with YouTube, Vimeo, DailyMotion. Example: [embed]https://www.youtube.com/watch?v=HCfPhZQz2CE[/embed]"

ISSUE: When I embed the example or my own URL [embed]https://www.vimeo.com/739328714[/embed], video does not display on the maintenance page, see https://ngcnetworkstv.com

Note: Bot feature is disabled as noted in instructions Vimeo video is public.

Plug-Ins: Akismet Anti-Spam (deactivated) All-In-One WP Migration (deactivated) Hosting (deactivated) WP-Maintenance Mode & Coming Soon (Active)

Embed-Bug1.pdf Embed-Bug2.pdf

girishpanchal30 commented 2 years ago

Hello @IlluminatePro, I have tested it with my local and it working fine for me. Can you please create a WP test instance( tastewp.com ) and share details here? Ref: https://tinyurl.com/2kpehkzs

@irinelenache Can you please test this issue with provided details?

Thanks

IlluminatePro commented 2 years ago

Thank you for your quick response. Can be seen here https:.//ngcnetworktv.com and created test site at https://proofreadjourney.s4-tastewp.com. Issue persists.

@irinelenache what additional details can I provide? Thank you for your help.

girishpanchal30 commented 2 years ago

Hello @IlluminatePro,

I have found the issue and it's fixed now. you can see the changes in the next plugin release.

As of now, you need to add the below filter in the active theme functions.php file.

add_filter(
    'wp_kses_allowed_html',
    function( $allowed_html = array() ) {
        return array(
            'iframe' => array(
                'src'             => array(),
                'height'          => array(),
                'width'           => array(),
                'frameborder'     => array(),
                'allowfullscreen' => array(),
                'data-*'          => true,
            ),
        );
    }
);

Thanks

IlluminatePro commented 2 years ago

Many thanks for the functions.php temp fix and I'll watch for the next release. Cheers!

IlluminatePro commented 2 years ago

Feature: it would be nice if the text field allowed HTML editing. I find if inserted it's auto removed. (e.g. &nbsp).

girishpanchal30 commented 2 years ago

@IlluminatePro If you would like to request a new feature, feel free to create a new ticket.

pirate-bot commented 1 year ago

:tada: This issue has been resolved in version 2.5.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: