search

Codeinwp / wp-maintenance-mode

Adds a splash page to your site that lets visitors know your site is down for maintenance. Full access to the back- & front-end is optional.
https://wordpress.org/plugins/wp-maintenance-mode/
159 stars 82 forks source link

Subscriber form is not registering subscribers [For non-migrated users] #334

Closed kushh23 closed 1 year ago

kushh23 commented 1 year ago

Description

Subscribe form is not registering subscribers on the instances which are not migrated to the Gutenberg changes made in the latest update.

The issue was initially reported on the wp.org forum but I was unable to replicate it before; as soon as I was able to I came here to report the issue.

How to replicate

  1. Install a Previous version of the plugin (I tested with v2.4.7).
  2. Activate the maintenance mode and enable the subscribe option from Settings > Modules.
  3. Open the site in incognito and do some dummy entries and then check the subscriber count, you will observe it is increasing with each entry.
  4. Now update the plugin to the latest version(v2.5.3) and don't migrate to the new Gutenberg changes.
  5. Go to Modules and empty the subscriber list so the counter is back at 0.
  6. Repeat step 3 with this version.
  7. You will observe the counter is stuck at 0 and the subscribe form is not registering new subscribers.

References

wp-maintenance-mode.2.4.7.zip

The page in version 2.4.7: image

This notice appears after the email entry[in version 2.4.7]: image

Subscriber count in v2.4.7: image

The page in version 2.5.3 (exactly the same ): image

and if you will enter the email in the input field in this version then you will also notice that the notice which says -

You are successfully subscribed, thanks

doesn't appear as well.

Subscriber count in v2.5.3: image

Wp.org ticket related to the issue.

Technical info

girishpanchal30 commented 1 year ago

Hey @kushh23, I have fixed the subscriber entry issue. Please check with this PR - Codeinwp/wp-maintenance-mode/pull/335

Thanks

irinelenache commented 1 year ago

@girishpanchal30 Tested the fix and the subscribe works fine now for non migrated users šŸš€

kushh23 commented 1 year ago

Hey @girishpanchal30 @irinelenache,

I have tried the plugin build and the issue still exists for me .

girishpanchal30 commented 1 year ago

@kushh23 Can you please share your test instance details here?

kushh23 commented 1 year ago

Hey @girishpanchal30,

I decided to do some more testing, so I deactivated it, and then after reactivating the plugin it worked for me! So the issue is fixed with the plugin build šŸ¤ŸšŸ™Œ

Thanks

pirate-bot commented 1 year ago

:tada: This issue has been resolved in version 2.5.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

kushh23 commented 1 year ago

Closing this as the bug is fixed and the new version is also released 10 days ago