Codeinwp / wp-maintenance-mode

Adds a splash page to your site that lets visitors know your site is down for maintenance. Full access to the back- & front-end is optional.
https://wordpress.org/plugins/wp-maintenance-mode/
159 stars 82 forks source link

Add landing pages #336

Closed arinaturcu closed 1 year ago

arinaturcu commented 1 year ago

Adds the new Landing Pages.

Closed #327.

github-actions[bot] commented 1 year ago

Plugin build for df5e32d9001a25013cace88f84d0a4b2fb7b15ce is ready :bellhop_bell:!

JohnPixle commented 1 year ago

I just tested the build on a TasteWP instance and it works perfect, nice Job @arinaturcu

I only noticed that the compression of the library images is pretty harsh. Not a critical issue, but perhaps we can do something about it (lowering the compression)? Happy to help with the screenshots if you need me to, I am not sure if these are auto-generated 🤔

Screenshot 2022-10-26 at 13 50 26

arinaturcu commented 1 year ago

Thank you for testing @JohnPixle! They are not auto generated, I took them. If you think they are OK in terms of structure, I can lower the compression and replace them. Otherwise, some new ones are welcomed 🚀

JohnPixle commented 1 year ago

@arinaturcu structure is fine, I just think compression is a bit weird, I see there are very rough edges in them. If you are doing it with Photoshop, I believe it must be a setting in the Image Quality dropdown in the Save for Web panel.

It looks like it is set to Nearest Neighbour (and this is preserving the rough edges). But I don't want to complicate you with this, I will be happy to send over new ones soon.

arinaturcu commented 1 year ago

@JohnPixle Okay, I'll leave them to you then. Thank you for helping with these 🚀

JohnPixle commented 1 year ago

Hey again @arinaturcu

So, I took a deeper look with the thumbnails, I think the issue with the overly sharp edges was coming from the resizing of the images, and not the actual compression. The original images appear to be big, and when resized they appear with the rough edges.

I took the initiative to provide the images to you in the final dimensions as they appear in the library, 380 x 405. I hope the dimensions are correct. If not, let me know.

I also safely compressed them a bit. Now all the thumbnails of the landing pages are only 174 KB, which is significantly less than before (an original image of a single landing page template used to be about 400KB). Hope it helps 👍🏻

I did this for all 3 thumbnail types, Landing pages, Maintenance and coming soon. I am attaching the Zips here.

landing-pages.zip Coming Soon.zip maintenance.zip

I would also like to point out two things:

1. New templates. Apart from the landing pages, in this version of the plugin, we have one new Coming Soon template. Link here.. We also have one more Maintenance template. Link here. The thumbnails are included in the zips.

2. Template names. For the Maintenance and Coming Soon templates I would advise to start using a bit more generic names (maintenance 1, maintenance 2 etc) instead of style-related names as we do now (modern , cover etc). I am suggesting this in order to keep things easy since we are going to add more of these templates in the future, and we may not be able to define a unique style name for each of them.

Let me know what you think and always happy to help for anything you may need.

arinaturcu commented 1 year ago

Great, @JohnPixle! 🚀 I will replace the screenshots and the names of the templates and add the new ones. I will come back with an update afterward.

Thank you!

irinelenache commented 1 year ago

@arinaturcu Tested and didn't find any problem in terms of functionality 🚀

After @JohnPixle's mentions are addressed and he approves it, this can be moved to Ready to merge

arinaturcu commented 1 year ago

Hey @JohnPixle, I made the changes. So have a look when you have some time and let me know if everything is fine 🚀

JohnPixle commented 1 year ago

@arinaturcu Thanks for the update, we are all good with the Thumbnails quality, thanks so much for taking care of it 🙂 👍🏻

I noticed two small issues though:

Wizard:

Screenshot 2022-10-28 at 10 54 53

Ordering of the templates

Screenshot 2022-10-28 at 10 47 33 Screenshot 2022-10-28 at 10 47 45

Let me know your thoughts and don't hesitate to ping me in case you need any clarifications on the above.

arinaturcu commented 1 year ago

@JohnPixle Thank you for catching these 😄 . Should be fixed now.

JohnPixle commented 1 year ago

@arinaturcu Just checked and all looks rock-solid. Thanks so much for taking care of them, looking forward to see them live. From my side it's a green light to merge! 🚀

pirate-bot commented 1 year ago

:tada: This PR is included in version 2.6.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: