search

Codeinwp / wp-maintenance-mode

Adds a splash page to your site that lets visitors know your site is down for maintenance. Full access to the back- & front-end is optional.
https://wordpress.org/plugins/wp-maintenance-mode/
159 stars 82 forks source link

Templates display & quality #347

Closed ineagu closed 1 year ago

ineagu commented 1 year ago

@HardeepAsrani I am not sure if it is Optimole, but the images don't look sharp, neither in the initial onboarding nor here: https://vertis.d.pr/i/ImQE83. They also get one on top of another.

HardeepAsrani commented 1 year ago

Can you look into it when you have time? I can't reproduce the overflow of images on my side but specially when you're using a ratina display, the images don't look very good, so we can use maybe better quality screenshots. @arinaturcu

arinaturcu commented 1 year ago

I can't reproduce the overflow of images on my side

I also couldn't, @ineagu can you provide some instructions on how to reproduce it?

Regarding the templates screenshots, sure we can replace them with better quality ones.

ineagu commented 1 year ago

it was on tastewp, so maybe something from their side, we can ignore it then and take care of the screenshots for both onboarding and templates screen.

arinaturcu commented 1 year ago

I also tested on Tastewp. Maybe there could be some CSS class conflicts. Did you have other plugins installed besides Optimole?

Anyway, I should note that it would be a good idea to prefix the CSS classes to avoid this.

JohnPixle commented 1 year ago

The images overflow is something that I couldn't replicate either.

Regarding the thumbnails though, we already had an issue prior to the last update, with images being harshly resized from their original size (which was quite big). Not sure if this problem stemmed from Optimole's compression or something else.

Attempting to fix the issue, I had personally re-created the thumbnails in the final sizes that would show up in the library (380 x 405), but I think this was partly a mistake, because when seen in a retina display, they will be scaled up and pixelated.

I did a quick export of the thumbnails in x2 the size, and I am uploading them in Zips here. I think we should test and see if this fixes the issue. I also have a MBP with retina display and I can check.

Please keep in mind that these thumbnails have already been optimised with tinypng. I am not sure if Optimole will add more compression on them, and if this will be an issue.

landing pages.zip coming soon.zip

👇🏻 Updated images, fixing the resolution error maintenance-updated.zip

Let me know if this helps and if I can be of any further assistance.

pirate-bot commented 1 year ago

:tada: This issue has been resolved in version 2.6.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: