Codeinwp / wp-maintenance-mode

Adds a splash page to your site that lets visitors know your site is down for maintenance. Full access to the back- & front-end is optional.
https://wordpress.org/plugins/wp-maintenance-mode/
159 stars 82 forks source link

Managed status from the network dashboard #356

Closed girishpanchal30 closed 1 year ago

girishpanchal30 commented 1 year ago

Close #295

github-actions[bot] commented 1 year ago

Plugin build for b34c898e8196f6cfc523559d94e66530bb0ae48c is ready :bellhop_bell:!

irinelenache commented 1 year ago

@girishpanchal30 I think this is the new PR for the feature and we'll close this one. Let me know if i'm wrong. Here are my findings:

You can check on this instance:

URL: https://calm-cat-guca.vertisite.cloud
Username: gigegexalo1538
Password: UiOokgaes8DNXdxVjf51
girishpanchal30 commented 1 year ago

@irinelenache I've fixed the mentioned issue with the most recent commit and closed the previous PR.

irinelenache commented 1 year ago

@girishpanchal30

The issues can be checked on the same instance

girishpanchal30 commented 1 year ago

@irinelenache

I think we should deactivate the mode on all subsites and have the individual option disabled, like we do when it's activated

Done

After adding the add_filter( 'wpmm_manage_from_network_dashboard', '__return_false' ); filter to functions.php

It seems working fine now, please test with the latest commit.

irinelenache commented 1 year ago

@girishpanchal30 Checked again and the subsites still aren't in sync with the network dashboard setting. You can try to enable/disable it and check the dashboard of every subsite to see if it was applied.

The filter is working now, maybe we can add a small note here about how to use the filter so the users won't have to check the docs if they are annoyed by the feature

girishpanchal30 commented 1 year ago

@irinelenache Let's add the network mode enable/disable option instead of the filter. Please re-check with the latest commit and let me know if you have any other suggestions. Ref: https://tinyurl.com/2h66o42r

Thanks

irinelenache commented 1 year ago

@girishpanchal30

girishpanchal30 commented 1 year ago

@irinelenache Fixed both issue, Please check with the latest commit.

irinelenache commented 1 year ago

@girishpanchal30 Did another round of testing and now everything works fine, thank you for the changes 🚀

pirate-bot commented 1 year ago

Plugin build for 8adbab25506e38bae8819b1d0d742556eacbb8ee is ready :bellhop_bell:!

pirate-bot commented 1 year ago

:tada: This PR is included in version 2.6.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: