Add Optimole checkbox in wizard

Codeinwp / wp-maintenance-mode

Adds a splash page to your site that lets visitors know your site is down for maintenance. Full access to the back- & front-end is optional.

159 stars 82 forks source link

Closed arinaturcu closed 1 year ago

arinaturcu commented 1 year ago

Add a checkbox in the wizard that if checked, going to the next step will install and activate Optimole.
Replace text
Replace the right top corner icon with an X one
Remove the Otter banner from the wizard
Change the style of the selected template

The test instance must not have installed the plugin before for the wizard to show, or it can be simulated with wp option update wpmm_fresh_install 1
If the Optimole checkbox is checked, and the Continue button is clicked, it should install and activate both Otter and Optimole
If the Optimole checkbox is checked, and the I don't want a template button is clicked, it should install and activate just Optimole
If the checkbox is unchecked it should behave like before.

pirate-bot commented 1 year ago

Plugin build for 3d6b2560e6469ec5a7a9f6375a46b26af11a94e6 is ready :bellhop_bell:!

irinelenache commented 1 year ago

@arinaturcu Tested and here is what i found:

[x] Maybe we can add the external link icon to the Otter and Optimole links https://vertis.d.pr/i/exdoeK Also the same in the Lightstart settings https://vertis.d.pr/i/Qzd6yq
[x] I'm getting a 500 error when i'm trying to import a template through the wizard https://vertis.d.pr/v/g2nWvE Also i'm getting a 500 error when i'm trying to import a template through Lightstart settings

The issues can be checked here:

 Admin area URL: https://soakpie.s1-tastewp.com/wp-admin 
 Username: irinel 
 Password: BfbKlIFetzQ

arinaturcu commented 1 year ago

@selul Here I also updated the @wordpress/eslint-plugin version from ^12.9.0 to ^14.0.0 to fix this error:

error eslint-plugin-jsdoc@37.9.7: The engine "node" is incompatible with this module. Expected version "^12 || ^14 || ^16 || ^17". Got "18.14.1"

Let me know if that's ok.

selul commented 1 year ago

@arinaturcu sure.

irinelenache commented 1 year ago

@arinaturcu Tested and the mentioned issues are fixed, thank you 🚀

Something else that happens after the last commits:

[x] If i uncheck the Optimole checkbox and also use the I don't want to use a template button, i'm getting a console error and nothing happens https://vertis.d.pr/i/4dGZ6w

Can be checked here:

 Admin area URL: https://freshlightstart.s2-tastewp.com/wp-admin 
 Username: irinel 
 Password: cCVza3Q73kU

arinaturcu commented 1 year ago

Thanks @irinelenache 🚀 Should be fixed now.

irinelenache commented 1 year ago

@arinaturcu Checked again and now everything's fine, thank you 🎉

pirate-bot commented 1 year ago

:tada: This PR is included in version 2.6.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: