search

Codeinwp / wp-maintenance-mode

Adds a splash page to your site that lets visitors know your site is down for maintenance. Full access to the back- & front-end is optional.
https://wordpress.org/plugins/wp-maintenance-mode/
159 stars 82 forks source link

Add the update page & include the sdk #386

Closed ineagu closed 1 year ago

ineagu commented 1 year ago

What problem does this address?

@vytisbulkevicius the new SDK is out, since this is our biggest product, it would be great if we can update the SDK & release it. There would be no upgrade page or extra pages.

What is your proposed solution?

Edit from Hardeep: We can move the settings from Options to a top-level admin menu and make sure every reference to it in code and links are migrated safely + integrate About page from SDK.

vytisbulkevicius commented 1 year ago

@ineagu, so we don't want to have the "about us" page integrated for this plugin? Then we don't need to add the code change but I want to be sure that this is what you meant with no extra pages.

ineagu commented 1 year ago

@vytisbulkevicius in the original spec, there is an optional argument for the function to add more tabs linking to some other pages. My message was that we should add just the about us page, without the optional tabs configured.

vytisbulkevicius commented 1 year ago

Link to the code example that needs to be added - https://github.com/Codeinwp/themeisle-sdk/pull/178

HardeepAsrani commented 1 year ago

I'll pause the release https://github.com/Codeinwp/wp-maintenance-mode/pull/388 here for this, @ineagu just to confirm one thing, right now WPMM doesn't add any top-level menu page. This mean we need to add a top-level menu page for this plugin to add the About page, right?

ineagu commented 1 year ago

@HardeepAsrani you are right, for me, I don't see any problem with creating a top-level menu setting, that can create more flexibility in the future.

If you see any UX issue, we can skip it too. As of now, I don't have any data on how much the About page helps, so is hard to judge, if not a major concern we can create the top-level setting and go with it & later evaluate.

Do you want me to create a dedicated issue for that?

HardeepAsrani commented 1 year ago

@ineagu No, this should do. We can just have a simple top-level menu with two pages, Settings that will have the existing plugin settings + About Us page added via SDK.

girishpanchal30 commented 1 year ago

Hey @vytisbulkevicius,

I've moved the plugin menu to the top level and added the about us page using SDK. Please check with attached PR https://github.com/Codeinwp/wp-maintenance-mode/pull/391

Thanks

pirate-bot commented 1 year ago

:tada: This issue has been resolved in version 2.6.8 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: