search

Codeinwp / wp-menu-icons

Easily add icons to your nav menu items.
https://wordpress.org/plugins/menu-icons/
GNU General Public License v2.0
81 stars 25 forks source link

Many icons missing #158

Closed nahasco closed 5 years ago

nahasco commented 5 years ago

Many icons from fontawesome are missing

radu-themeisle commented 5 years ago

@nahasco can you point out some of the missing icons? They should all be there.

nahasco commented 5 years ago

Xbox, Playstation, Microsoft, Nintendo.

radu-themeisle commented 5 years ago

The plugin uses the icons provided by Fontawesome v4.7 so there will be icons from v5 which will not be present. You can download the icons you need and upload them to your website: http://prntscr.com/o7bu8t[](url)

nahasco commented 5 years ago

The plugin uses the icons provided by Fontawesome v4.7 so there will be icons from v5 which will not be present. You can download the icons you need and upload them to your website: http://prntscr.com/o7bu8t[](url)

Why dont you guys update the plugin?! Fontawesome's current version is 5.9 and you're on 4.7?!

radu-themeisle commented 5 years ago

We tried when v5 came out but unfortunately the risk of conflicts is very high and users would have to manually change some icons which have a different UTF-8 code in v5.x than in v4.7. At the moment themes and plugins using v4.7 are still widespread and icons not showing up when using v5 is a huge risk that would not benefit users. Even Fontawesome doesn't recommend using v4.7 and 5.x alongside and also don't provide a "clean way" to transition other than modifying the code which would definitely cause issues on the front end. For the moment the safest option is to download a v5.x icon and upload it via the plugin.

nahasco commented 5 years ago

Oh, I understand. Porto theme is using the latest version though.

On Thu, Jun 27, 2019, 1:22 PM radu notifications@github.com wrote:

We tried when v5 came out but unfortunately the risk of conflicts is very high and users would have to manually change some icons which have a different UTF-8 code in v5.x than in v4.7. At the moment themes and plugins using v4.7 are still widespread and icons not showing up when using v5 is a huge risk that would not benefit users. Even Fontawesome doesn't recommend using v4.7 and 5.x alongside and also don't provide a "clean way" to transition other than modifying the code which would definitely cause issues on the front end. For the moment the safest option is to download a v5.x icon and upload it via the plugin.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Codeinwp/wp-menu-icons/issues/158?email_source=notifications&email_token=ALYU3HJINQQVVNGODV3XKCLP4SIFVA5CNFSM4H3GSTZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYWVP3A#issuecomment-506288108, or mute the thread https://github.com/notifications/unsubscribe-auth/ALYU3HPRPLREOXFPSMWCZ7LP4SIFVANCNFSM4H3GSTZQ .

radu-themeisle commented 5 years ago

Thank you for the tip, we'll look into what they've done and how they managed to handle potential conflicts 😃

richrd commented 5 years ago

What about providing the two major versions of FontAwesome and letting the user select between FontAwesome 4 and FontAwesome 5?