Neve upsell appears even when Neve is already installed

Codeinwp / wp-menu-icons

Easily add icons to your nav menu items.

https://wordpress.org/plugins/menu-icons/

GNU General Public License v2.0

81 stars 25 forks source link

Closed mghenciu closed 2 years ago

mghenciu commented 2 years ago

I think the upsell should appear only if Neve is not installed. After Neve is installed the Upsell Toast should disappear:

selul commented 2 years ago

@mghenciu, this looks more accurate tagged as a bug rather than small-improvement, what do you think?

mghenciu commented 2 years ago

It may be the way it was intended, so that's why I tagged it with small-improvement. Added now the bug label, also.

Essentially the idea is to have most common flows covered:

I have Neve installed, and I install Menu Icons -> the upsell should be hidden
I have Menu Icons installed with the Neve upsell visible, and I install Neve -> the upsell should become hidden after Neve is installed
I install Menu Icons and Neve is not present -> show the upsell

girishpanchal30 commented 2 years ago

Hey @mghenciu, I have implemented above mentioned flow. Please check and do let me know if you have any issues. Thanks

mghenciu commented 2 years ago

@girishpanchal30 , tested now and looks good! The Neve upsell, doesn't appear anymore if Neve is already Installed & Activated.

pirate-bot commented 2 years ago

:tada: This issue has been resolved in version 0.13.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: