Upgrade font awesome library

Codeinwp / wp-menu-icons

Easily add icons to your nav menu items.

https://wordpress.org/plugins/menu-icons/

GNU General Public License v2.0

81 stars 25 forks source link

Upgrade font awesome library #222

Closed girishpanchal30 closed 2 years ago

girishpanchal30 commented 2 years ago

Close #201, #216

pirate-bot commented 2 years ago

Plugin build for 157a974ba1c94202532aae76d3f470d010915259 is ready :bellhop_bell:!

Download build

irinelenache commented 2 years ago

@girishpanchal30 I can't make the new icons work, please let me know if i missed anything. I tried to add them in more ways https://vertis.d.pr/9VWubn and they will appear as empty when i try to add them (both in settings and frontend) https://vertis.d.pr/mayOGX

girishpanchal30 commented 2 years ago

@irinelenache Can you please share your test instance details here?

irinelenache commented 2 years ago

Sure,

 Admin area URL: https://otter-fse.s2-tastewp.com/wp-admin 
 Username: irinel 
 Password: wo1Qr78VYus

girishpanchal30 commented 2 years ago

@irinelenache I think you have tested with Pro icons, Can you please check with Free icons here: https://fontawesome.com/search?m=free

girishpanchal30 commented 2 years ago

@irinelenache https://www.awesomescreenshot.com/image/31202424?key=4ecff8ce3569b64a2b370fa05aceab34

irinelenache commented 2 years ago

@girishpanchal30 I used icons from the link you provided, but all of them appear as pro actually, even if the search is filtered for Free. I also tried with Brands icons and they still don't work.

Can you show me a video of making them work or you can send here some free icons that i will use?

girishpanchal30 commented 2 years ago

@irinelenache I'm not sure why the filter listed pro icons. but font awesome provides only 2016 icons. Ref: https://tinyurl.com/2mwwjqsf

irinelenache commented 2 years ago

@girishpanchal30 Managed to test it on a fresh instance and it seems to work, found some problems though:

[ ] Icons work only when they are added as solid (for example fa-solid fa-baseball). If i add them as regular they won't load at all and if i add them as thin, they will look like this https://vertis.d.pr/mSm1Hi
[x] Some multi word icons don't work, i don't know exactly why is that Multi word icons that work: fa-solid fa-bed-pulse , fa-book-journal-whills , fa-solid fa-bezier-curve Multi word icons that don't work: fa-solid fa-bitcoin-sign , fa-solid fa-bowl-rice , fa-solid fa-baseball-bat-ball

You can check the issues on this instance:

 Admin area URL: https://menu-icons.s2-tastewp.com/wp-admin 
 Username: irinel 
 Password: RBB1asmp81E

girishpanchal30 commented 2 years ago

@irinelenache Fixed above mentioned issue, Please check with the latest commit.

irinelenache commented 2 years ago

@girishpanchal30 The second issue is fixed, thank you 👍 But for the first one, the problem is still happening

girishpanchal30 commented 2 years ago

@irinelenache I think the fa-solid fa-baseball free icon is available for the solid category only. you can check here: https://fontawesome.com/search?q=baseball&m=free&s=regular

irinelenache commented 2 years ago

@girishpanchal30 Thank you, i realised thin and light work only in the pro version. This is good to merge now 🚀

pirate-bot commented 2 years ago

:tada: This PR is included in version 0.13.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: