Codeinwp / wp-menu-icons

Easily add icons to your nav menu items.
https://wordpress.org/plugins/menu-icons/
GNU General Public License v2.0
81 stars 25 forks source link

Icons don't appear with FSE themes #244

Open MarinescuLucia opened 1 year ago

MarinescuLucia commented 1 year ago

Description

The icons don't appear with FSE themes either in the editor or on the published page. Is this intentional for FSE themes?

Step-by-step reproduction instructions

  1. Install an FSE theme
  2. Go to the editor
  3. Select a menu item and add an icon to it
  4. Check that it doesn't appear in the editor or on the published page.

Screenshots, screen recording, code snippet or Help Scout ticket

Reported here.

Environment info

No response

Is the issue you are reporting a regression

No

HardeepAsrani commented 1 year ago

Just adding a bit more context here for Vytis:

This functionality was part of https://github.com/Codeinwp/gutenberg-menu-icons and was shared between Otter & WP Menu Icons for some time. Later we decided to manage it separately in Otter to avoid the complex setup Otter had and archived that repo.