search

Codeinwp / wp-menu-icons

Easily add icons to your nav menu items.
https://wordpress.org/plugins/menu-icons/
GNU General Public License v2.0
81 stars 25 forks source link

Button from notice recommending Neve has fixed width which is causing issues in other languages #252

Closed rodica-andronache closed 1 year ago

rodica-andronache commented 1 year ago

Description

The notice used for recommending Neve has a button with a fixed width, which doesn't look good in different languages, other than english

Step-by-step reproduction instructions

  1. Activate the plugin
  2. Create a menu with icons from the plugin
  3. Check the notice recommending Neve
  4. Try to change the text of the button in another language -> The button has a fixed width which doesn't accommodate longer text. Annotation-Annotation on 2023-08-05 at 12-26-17 png

Screenshots, screen recording, code snippet or Help Scout ticket

https://twitter.com/marcoandrei/status/1687520466817220608?s=20

Environment info

No response

Is the issue you are reporting a regression

No

girishpanchal30 commented 1 year ago

@rodica-andronache I've reviewed this issue and fixed it with the attached PR https://github.com/Codeinwp/wp-menu-icons/pull/254

irinelenache commented 1 year ago

@girishpanchal30 Tested and the issue is fixed now 👍

pirate-bot commented 1 year ago

:tada: This issue has been resolved in version 0.13.7 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: