Codeinwp / wp-menu-icons

Easily add icons to your nav menu items.
https://wordpress.org/plugins/menu-icons/
GNU General Public License v2.0
81 stars 25 forks source link

Hide Label does not work in Menu Icons Settings #265

Closed AndreeaCristinaRadacina closed 8 months ago

AndreeaCristinaRadacina commented 10 months ago

Description

A user reported that even if he set it to hide the label, it is still displayed. I checked and indeed, if you select "No" for Hide Label inside the Menu Icons Settings, it has no effect. It works only when I individually set it while editing an icon.

Step-by-step reproduction instructions

  1. Go to Appearance> Menus.
  2. Expand the Menu Icons Settings.
  3. Switch to Current Menu.
  4. Under the Hide label, select Yes.

Screenshots, screen recording, code snippet or Help Scout ticket

https://wordpress.org/support/topic/want-to-see-icon-without-the-label/#post-17191177

Environment info

No response

Is the issue you are reporting a regression

No

girishpanchal30 commented 9 months ago

@AndreeaCristinaRadacina I've reviewed this issue and fixed it with this PR https://github.com/Codeinwp/wp-menu-icons/pull/268

irinelenache commented 9 months ago

@girishpanchal30 The issue is fixed now, thank you 👍

pirate-bot commented 8 months ago

:tada: This issue has been resolved in version 0.13.8 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: