Codeinwp / wp-menu-icons

Easily add icons to your nav menu items.
https://wordpress.org/plugins/menu-icons/
GNU General Public License v2.0
81 stars 25 forks source link

fix: add filter for promotions and improved readme #279

Closed preda-bogdan closed 5 months ago

preda-bogdan commented 5 months ago

Summary

After merging the SDK changes introduced here: https://github.com/Codeinwp/themeisle-sdk/pull/217 We can use the filter here to disallow specific promotions from running.

Improved the Readme to link back to the sources of the plugin and of the SDK.

UnitTest is provided for the SDK changes. https://github.com/Codeinwp/themeisle-sdk/pull/217

Will affect the visual aspect of the product

NO

Screenshots

Test instructions

To these changes, you need:

  1. To use the linked SDK build
  2. Set the install option to an older date wp option update wp_menu_icons_install 1685187068
  3. Add a page with 2 or more images and publish it.

How to test:

  1. Check that the promotion is no longer visible on the image block when 2 or more images are being added to a published page. Check this after publishing the page with the images, it should be visible during edit.

Check before Pull Request is ready:

Closes Codeinwp/themeisle#1634.

pirate-bot commented 5 months ago

Plugin build for 40f70a1c63211be1a7854b469a2f5a071a2e43b7 is ready :bellhop_bell:!

pirate-bot commented 5 months ago

:tada: This PR is included in version 0.13.10 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: