Codelanx / CodelanxLib

Library for Codelanx plugins. Public use is allowed, but must be credited
Other
14 stars 4 forks source link

Argument mismatching in #onCommand #14

Closed 1Rogue closed 9 years ago

1Rogue commented 9 years ago

https://github.com/CodeLanx/CodelanxLib/blob/master/src/main/java/com/codelanx/codelanxlib/command/CommandNode.java#L145

Uses the string args for comparison, which means commands with matching args will get cut off too early. Should do an object comparison of the child on a second traverse, or a depth check on a parent recursion. Alternatively just write off args on a manual traversion.

1Rogue commented 9 years ago

https://github.com/CodeLanx/CodelanxLib/commit/5ec03fad65374349b9d13702a6e63cce31103936