search

CodelyTV / php-ddd-example

🐘🎯 Hexagonal Architecture + DDD + CQRS in PHP using Symfony 7
https://pro.codely.tv/library/ddd-en-php
2.96k stars 1.08k forks source link

Doctrine YAML mapping is going to be deprecated in version 3 #199

Closed DanielRamosAcosta closed 4 years ago

DanielRamosAcosta commented 4 years ago

Greetings CodelyTV folks!

I'm not a PHP dev, but I've been investigating about Doctrine (to see if I can grab any implementation strategies to my node project) and I've found that the YAML mapping is going to be deprecated in version 3.

I think this is where ports and adapters architecture shines. The framework has deprecated something but this should only impact the implementation details of your repositories (video migrating from YAML mapping? 🙏 ).

I would create a PR, but I'm not a PHP dev and I wouldn't know what would be the best implementation, so I leave this here for you experts 😉.

Regards!

abiagini commented 4 years ago

What a great idea for a video, will be awesome to view that. 🎥 + 🧽 = 🤩

rgomezcasas commented 4 years ago

That would be an awesome video, yes. 😬

We already migrated almost all of our yamls to xml, but there are 3 remaining:

  1. https://github.com/CodelyTV/php-ddd-example/blob/master/src/Mooc/Videos/Infrastructure/Persistence/Doctrine/VideoTitle.orm.yml
  2. https://github.com/CodelyTV/php-ddd-example/blob/master/src/Mooc/Videos/Infrastructure/Persistence/Doctrine/VideoType.orm.yml
  3. https://github.com/CodelyTV/php-ddd-example/blob/master/src/Mooc/Videos/Infrastructure/Persistence/Doctrine/Video.orm.yml

Feel free to create a pull request (using the other xml's as an example) 😬

If you don't feel confident enough, don't worry. We'll do that ourselves instead. ✌️

Thanks for the advice!!!