CodelyTV / pr-size-labeler

🏷 Visualize and optionally limit the size of your Pull Requests
https://github.com/marketplace/actions/pull-request-size-labeler
MIT License
343 stars 61 forks source link

Validation failed #12

Closed JavierSegoviaCordoba closed 4 years ago

JavierSegoviaCordoba commented 4 years ago

The PR isn't labeled and I can see the next message in logs:

{
  "message": "Validation Failed",
  "errors": [
    {
      "resource": "Label",
      "field": "name",
      "code": "missing_field"
    }
  ],
  "documentation_url": "https://developer.github.com/v3/issues/#edit-an-issue"
}
rgomezcasas commented 4 years ago

Cold you attach all the output? (removing all private information)

JavierSegoviaCordoba commented 4 years ago

Yesterday was working, maybe the last updated between yesterday and today breaks it.

Output:

Run codelytv/pr-size-labeler@v1
/usr/bin/docker run --name c27d31284bd8650c994559a2968ca64a0082f8_45a188 --label c27d31 --workdir /github/workspace --rm -e INPUT_GITHUB_TOKEN -e INPUT_XS_MAX_SIZE -e INPUT_S_MAX_SIZE -e INPUT_M_MAX_SIZE -e INPUT_L_MAX_SIZE -e INPUT_FAIL_IF_XL -e INPUT_MESSAGE_IF_XL -e HOME -e GITHUB_JOB -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/*********/*********":"/github/workspace" c27d31:284bd8650c994559a2968ca64a0082f8  "***" "10" "100" "500" "1000" "false" "This PR is sooooo big!! 😳"
GNU bash, version 5.0.0(1)-release (x86_64-alpine-linux-musl)
Copyright (C) 2019 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Total modifications: 6
Labeling pull request with size/xs
Final labels: "","size/xs"
{
  "message": "Validation Failed",
  "errors": [
    {
      "resource": "Label",
      "field": "name",
      "code": "missing_field"
    }
  ],
  "documentation_url": "https://developer.github.com/v3/issues/#edit-an-issue"
}
rgomezcasas commented 4 years ago

Fixed in https://github.com/CodelyTV/pr-size-labeler/releases/tag/v1.4.2 And pushed to the v1 tag. It should work as usual, can you confirm it? :)

Thanks!!

JavierSegoviaCordoba commented 4 years ago

It is working Rafa, thank you 😃

JavierSegoviaCordoba commented 4 years ago

I think there is a problem with some JSON. This time is a different error and the size changed to size/l, I don't know if it is related.

{
  "message": "Problems parsing JSON",
  "documentation_url": "https://developer.github.com/v3/issues/#edit-an-issue"
}
JavierSegoviaCordoba commented 4 years ago

Yeah, it seems size/s and size/m are working but size/l is failing

rgomezcasas commented 4 years ago

I couldn't replicate that in #14 :/

Sometimes GH Actions uses an old cached version, could you try to hardcode the use of v1.4.2 version?

- uses: codelytv/pr-size-labeler@v1.4.2
JavierSegoviaCordoba commented 4 years ago

I will come here when we do a PR of this size, I will close meanwhile.

rgomezcasas commented 4 years ago

Cool! Thanks!

JavierSegoviaCordoba commented 4 years ago

It works :)