Closed erodewald closed 6 months ago
actually, if i keep the github_api_url: 'api.github.com'
that comes from the example, it does not label my prs at all. it only worked after i omitted the line. it took me quite a while to figure it out 😄
actually, if i keep the
github_api_url: 'api.github.com'
that comes from the example, it does not label my prs at all. it only worked after i omitted the line. it took me quite a while to figure it out 😄
Nice!
There were two potential issues:
http://
which would break if copiedBoth have seen been addressed by #57 and #62 respectively.
By default, GitHub and its variants include an
GITHUB_API_URL
environment variable, so the addition ofgithub_api_url
just increased code complexity, reduced maintainability, and actually reduced flexibility since it assumeshttps://
. The latter meant I was not able to simply pass in$GITHUB_API_URL
, because it became an invalid url (e.g.,https://https://my-enterprise.url.com/api/v3
).