CodelyTV / pr-size-labeler

🏷 Visualize and optionally limit the size of your Pull Requests
https://github.com/marketplace/actions/pull-request-size-labeler
MIT License
343 stars 61 forks source link

Document required permissions #47

Closed adrianjost closed 3 months ago

adrianjost commented 1 year ago

It took me a bit of time to figure out which permissions this actions needs.

In my case, adding the following worked. Maybe that should be added to the README.

jobs:
  labeler:
    ...
    permissions:
      issues: write
      pull-requests: write
    steps:
      ...
EngJay commented 1 year ago

+1 - after removing the github url per #40, the action runs without indication that the lack of permissions is preventing it from labeling PRs, which led me here.

JavierCane commented 1 year ago

Good one. Thanks for opening the issue and providing the actual fix for it.

you can expect we work on this in the upcoming days/weeks at most. If you want, we would really appreciate opening a PR modifying the current README.md in order to reflect this by default and we would merge it even sooner.

Thanks!

adrianjost commented 1 year ago

I didn't open a PR yet, because I've used the permission stuff myself for the first time here. So I don't feel comfortable writing any documentation regarding that. I don't even know if any other potential permission defaults might affect my solution, so it only works in my environment and in others more permissions would be needed. I have no idea.

My main intent for this Issue was, to provide some information in case someone struggles with the same setup issue and hoping that someone who actually understands what I did would write some documentation eventually.

EngJay commented 1 year ago

@JavierCane I'll do it after work if want to assign it to me.

AlmogBaku commented 1 year ago

adding the permission to the issues actually solved my issue!