CodelyTV / pr-size-labeler

🏷 Visualize and optionally limit the size of your Pull Requests

https://github.com/marketplace/actions/pull-request-size-labeler

MIT License

336 stars 58 forks source link

fix: regex pattern matching #63

Open kounoike opened 10 months ago

kounoike commented 10 months ago

50 didn't fix #38.

because [[ "abc" == $pattern ]] is simple string match. for regex match, should be [[ "abc" =~ $pattern ]].

this PR fix it.

this PR also fix document. ignore pattern is regex, NOT glob.

johnlk commented 5 months ago

This change takes the wildcard matching and switches us to regex matching. Both are acceptable options. As a point of opinion, wildcard matching feels more ergonomic.

If we did want to support regex matching, maybe this should be another param like regex_files_to_ignore?