search

CodelyTV / scala-basic-skeleton

🧬🌱 Scala Basic Skeleton: Template for bootstrapping your new Scala project following idiomatic best practices.
https://pro.codely.com/library/introduccion-a-scala-29386/63278/about/
MIT License
15 stars 22 forks source link

scalastyle ImportOrderChecker rule seems vendor-specific #2

Closed vicaba closed 7 years ago

vicaba commented 7 years ago

I think that the parameters of the ImportOrderChecker rule should be vendor agnostinc for a bootstrapping template. https://github.com/CodelyTV/scala_bootstrap/blob/0eef0ff61c5160aec0c59fde3a354351be221831/scalastyle-config.xml#L220 (<parameter name="group.letgo">com\.letgo\..*</parameter>) is not vendor agnostic.

JavierCane commented 7 years ago

Good one!

Fixed in commit https://github.com/CodelyTV/scala_bootstrap/commit/5f52607d2862ad05ced0c534b91a3928e2cfccc7 :) thx!