CodelyTV / vue-progressive-migration-course

21 stars 9 forks source link

Fix event-stream vulnerability issue #1

Open JavierCane opened 5 years ago

JavierCane commented 5 years ago

We have the following two security alerts opened by GitHub:

image image

These security bugs are related to the just published vulnerabilities on the event-stream package in versions 3.3.6 and later. Here we can find more information about it:

Seeking for the usage of the event-stream package in the examples, I've found the following occurrences:

It seems to be added as a transitive dependency by the ps-tree@^1.1.0 package, which is added by the pstree.remy@^1.1.0 one, added by the nodemon@^1.11.0 one. This nodemon package is the one we really ask for in our package.json.

Searching for related issues, we can see the following ones in the nodemon repo:

The commit referenced as a fix for the vulnerability doesn't contain the removal of the pstree[.remy] dependency, however, they explicitly claim it solves it.

@juanmaguitar:

juanmaguitar commented 5 years ago

@JavierCane nodemon package is a package only needed for development so: